fix: signatures are now verifiable#15
Merged
Merged
Conversation
line-o
commented
Jan 12, 2026
The return of crypto:hmac#4 cannot be passed to util:base64-encode-url-safe() as that will double-encode the base64 encoded value. A simple translate operation will turn the base64 encoded value into a url-safe one that is suitable for use here. As a result JWTs are now externally verifiable by other tools as jwt.io's token debugger.
Since exist@latest cannot pass until the crypto lib is available I marked it as experimental.
The spec does not care but why have extra bytes in memory as this is never read by users directly.
line-o
force-pushed
the
fix/jwt-compat
branch
from
6c2a8e8 to
e11447e
Compare
Member
Author
|
@duncdrum continue-on-error is set |
line-o
commented
Jan 12, 2026
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest | ||
| continue-on-error: ${{ matrix.experimental }} |
Member
Author
|
I think updating all build-tools and building on the latest LTS of node is not in scope for this PR |
|
🎉 This PR is included in version 2.0.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The return of crypto:hmac#4 cannot be passed to util:base64-encode-url-safe() as that will double-encode the base64 encoded value. A simple translate operation will turn the base64 encoded value into a url-safe one that is suitable for use here.
As a result JWTs are now externally verifiable by other tools as jwt.io's token debugger.